Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MapPublicIpOnLaunch #285

Merged
merged 1 commit into from
Sep 16, 2014
Merged

add MapPublicIpOnLaunch #285

merged 1 commit into from
Sep 16, 2014

Conversation

hden
Copy link
Contributor

@hden hden commented Sep 10, 2014

fix #263

This option is visible in the subnet status, but only modifiable from another API call.

resource "aws_subnet" "main" {
    vpc_id = "${aws_vpc.main.id}"
    cidr_block = "10.0.1.0/24"
    map_public_ip_on_launch = true
}

Depends on: mitchellh/goamz#95
Related to: #214, #252

@levinotik
Copy link

👍

@pearkes
Copy link
Contributor

pearkes commented Sep 16, 2014

Great, merging this and going to cc you on the doc additions. Thank you very much!

pearkes added a commit that referenced this pull request Sep 16, 2014
@pearkes
Merge pull request #285 from hden/263
ee24fce 
add MapPublicIpOnLaunch
@pearkes pearkes merged commit ee24fce into hashicorp:master Sep 16, 2014
@pearkes
Copy link
Contributor

pearkes commented Sep 16, 2014

@hden Although both these and the goamz changes look fine, I'm getting the following back from Amazon after running the acceptance tests. Did you see this?

* Error modify subnet attributes: The action ModifySubnetAttribute is not valid for this web service. (InvalidAction)

Can you verify the acceptance tests pass for you?

make testacc TEST=github.com/hashicorp/terraform/builtin/providers/aws TESTARGS='-run TestAccAWSSubnet'

@pearkes
Copy link
Contributor

pearkes commented Sep 16, 2014

Confusing, as your changes match the documentation entirely. Not sure why this would be the case.

@pearkes pearkes mentioned this pull request Sep 16, 2014
Merged
pearkes added a commit that referenced this pull request Sep 16, 2014
@pearkes
providers/aws: fix tests for subnet map_public_ip, add docs
9fc775e 
This working depends on merging mitchellh/goamz#109

Related: #285

cc/ @hden
@pearkes
Copy link
Contributor

pearkes commented Sep 16, 2014

Okay! See related goamz issue and commit above – we need a higher EC2 API version for this to work. That's a pending pull into goamz, hopefully we can merge that without issue.

@hden
Copy link
Contributor Author

hden commented Sep 16, 2014

Thanks @pearkes!

@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws] enable auto-assign public IP within subnets
3 participants
@hden @levinotik @pearkes